sysdump: Fix empty namespace error #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
approved these changes
Dec 12, 2022
pchaigno
force-pushed
the
pr/pchaigno/fix-sysdump-empty-namespace
branch
from
6c0d2d8 to
3b21172
Compare
squeed
approved these changes
Dec 12, 2022
squeed
requested changes
Dec 12, 2022
Commit e8cfcc7 added an autodetection feature for the Cilium namespace, but because of a Golang error, never actually wrote it to the Collector's options. The 'o' variable is never used after being written to. This commit fixes it. Fixes: e8cfcc7 ("sysdump: auto detect namespace from list of defaults.") Signed-off-by: Paul Chaignon <[email protected]>
Commit e8cfcc7 ("sysdump: auto detect namespace from list of defaults.") implemented autodetection for the cilium-agent namespace but not for the cilium-operator namespace. It however cleared both --cilium-operator-namespace and --cilium-namespace's default values, thus causing collection of the cilium-operator deployment to fail all the time. This commit fixes it by implementing namespace detection for cilium-operator. Fixes: e8cfcc7 ("sysdump: auto detect namespace from list of defaults.") Signed-off-by: Paul Chaignon <[email protected]>
pchaigno
force-pushed
the
pr/pchaigno/fix-sysdump-empty-namespace
branch
from
3b21172 to
36b7aa8
Compare
squeed
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
I'll note that if we implemented #1083 and failed CI on any warning, this sort of regression wouldn't happen.
Fixes: #1289
Fixes: #1132
cc @tommyp1ckles