Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add wait for no operation for cleaning up GKE #1251

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Dec 1, 2022

When a workflow cancels, the clean-up job cannot delete clusters in the provisioning state. With this commit, the clean-up job will wait for no operation on clusters before deleting the resources.

Fixes: #940

When a workflow cancels, the clean-up job cannot delete clusters
in the provisioning state. With this commit, the clean-up job will
wait for no operation on clusters before deleting the resources.

Signed-off-by: Birol Bilgin <[email protected]>
@brlbil brlbil temporarily deployed to ci December 1, 2022 14:59 Inactive
@brlbil brlbil marked this pull request as ready for review December 1, 2022 15:49
@brlbil brlbil requested review from a team as code owners December 1, 2022 15:49
@brlbil brlbil requested a review from nbusseneau December 1, 2022 15:49
@brlbil
Copy link
Contributor Author

brlbil commented Dec 1, 2022

I did not add any run example, because this PR is basically copy of another on Cilium

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 1, 2022
@tklauser tklauser merged commit cdad6d5 into master Dec 1, 2022
@tklauser tklauser deleted the pr/brlbil/ci-gke-cleanup branch December 1, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: GKE-based: network "default" does not have available private IP space in 10.0.0.0/8 to reserve a /14 block
3 participants