Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Exclude non-running pods from total Cluster Pods count #1236

Merged
merged 1 commit into from
Nov 28, 2022
Merged

status: Exclude non-running pods from total Cluster Pods count #1236

merged 1 commit into from
Nov 28, 2022

Conversation

felfa01
Copy link
Contributor

@felfa01 felfa01 commented Nov 28, 2022

Since CEPs are cleaned up for Completed Pods, these pods should not be considered for total Cluster Pods count.

Fixes: #1235

Signed-off-by: flxman [email protected]

@felfa01 felfa01 requested a review from a team as a code owner November 28, 2022 13:29
@felfa01 felfa01 requested a review from joamaki November 28, 2022 13:29
@felfa01 felfa01 temporarily deployed to ci November 28, 2022 13:29 Inactive
status/k8s.go Outdated Show resolved Hide resolved
@felfa01 felfa01 changed the title status: Exclude Completed pods from total Cluster Pods count status: Exclude non-running pods from total Cluster Pods count Nov 28, 2022
status/k8s.go Outdated Show resolved Hide resolved
Since CEPs are cleaned up for non-running Pods, these pods should not be considered for total Cluster Pods count.

Fixes: #1235

Signed-off-by: flxman <[email protected]>
Co-Authored-By: Tobias Klauser <[email protected]>
@felfa01 felfa01 temporarily deployed to ci November 28, 2022 14:19 Inactive
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cilium status shows completed pods as unmanaged
2 participants