connectivity: add --collect-sysdump-on-failure flag #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which allows to collect, whenever a test fails, a more significant sysdump before the CLI cleans up any state. To allow the same level of configurability, the "connectivity test" command now supports the same flags used by the "sysdump" command. These flags are all prefixed by "--sysdump-". Signed-off-by: Gilberto Bertin <[email protected]>
Extract this logic into initSysdumpFlags and make it generic so that it can be used both by internal/cli/cmd/sysdump.go and internal/cli/cmd/connectivity.go. Signed-off-by: Gilberto Bertin <[email protected]>
pchaigno
approved these changes
Nov 23, 2022
jibi
added
the
ready-to-merge
maintainer-s-little-helper
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which allows to collect, whenever a test fails, a more significant
sysdump before the CLI cleans up any state.
To allow the same level of configurability, the "connectivity test"
command now supports the same flags used by the "sysdump" command.
These flags are all prefixed by "--sysdump-".