test/connectivity: Add a bit more logging around Hubble connections #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
approved these changes
Nov 9, 2022
squeed
force-pushed
the
collect-flows-errors
branch
from
b4cc27f to
5bfe5ea
Compare
When connections to hubble fail, there currently isn't enough information to debug the issue after-the-fact. So, add in a few more debug lines to try and get to the bottom of the problem. Also, bump the connection timeout from 10 to 30 seconds. Signed-off-by: Casey Callendrello <[email protected]>
squeed
force-pushed
the
collect-flows-errors
branch
from
5bfe5ea to
1ca8202
Compare
|
Needed to add a waitgroup just to stop some misleading log ordering. It doesn't have any correctness implications. |
tklauser
approved these changes
Nov 10, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connections to hubble fail, there currently isn't enough information to debug the issue after-the-fact. So, add in a few more debug lines to try and get to the bottom of the problem.
Also, bump the connection timeout from 10 to 30 seconds.
Signed-off-by: Casey Callendrello [email protected]