Improvements for kube-proxy detection and replacement

[ksankeerth]

The current implementation tries to replace the kube-proxy for k3s and doesn't honor the value set for kube-proxy replacement by users. This PR fixes those issues.

Fixes: #1004
Signed-off-by: shankeerthan-kasilingam [email protected]

[brb]

@ksankeerth Thanks for the fix! Do you plan to add the k3s detection in a separate PR?

[ksankeerth]

@ksankeerth Thanks for the fix! Do you plan to add the k3s detection in a separate PR?

I think we can use k.flavor.Kind detect k3s cluster instead of annotations.

https://github.com/cilium/cilium-cli/pull/1162/files#diff-70c8da281ad8db17039130d2e7ad09aa2fc7db3f6d44217e6db0764bef731fffR178

[tklauser]

Thanks

[tklauser]

@ksankeerth It looks like this branch picked up a merge conflict. Could you please rebase on top of latest master branch?

[ksankeerth]

@ksankeerth It looks like this branch picked up a merge conflict. Could you please rebase on top of latest master branch?

Thanks for the review. Rebased.

One CI checks seems to be failed. I'll look into it.

[tklauser]

@ksankeerth It looks like this branch picked up a merge conflict. Could you please rebase on top of latest master branch?

Thanks for the review. Rebased.

One CI checks seems to be failed. I'll look into it.

Thanks. The failing CI check looks like a known flake. I've re-triggered the test to verify.

[tklauser]

Thanks for your contribution @ksankeerth!