helm: Add support for remote chart version #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
tam/dynamic-helm-version
branch
from
6ed0b77 to
f40adea
Compare
sayboras
force-pushed
the
tam/dynamic-helm-version
branch
from
f40adea to
09199d4
Compare
sayboras
force-pushed
the
tam/dynamic-helm-version
branch
from
09199d4 to
2b9f0ea
Compare
michi-covalent
approved these changes
Sep 5, 2022
kaworu
reviewed
Sep 5, 2022
sayboras
force-pushed
the
tam/dynamic-helm-version
branch
from
2b9f0ea to
6f1a22c
Compare
squeed
reviewed
Sep 5, 2022
|
Does it make sense for |
Good point, this will help to avoid double download (into temp dir) as what Alex mentioned above. I will adjust the patch soon. |
This commit is to rename newChartFromCiliumVersion function to newChartFromEmbeddedFile. Signed-off-by: Tam Mach <[email protected]>
Currently, the cilium charts are embedded inside cilium cli binary, which will require a new cilium/charts bump in go.mod and then a new release for cilium-cli. It's making sense to do so if some other code changes are required to make installation working for new chart version, but most of the time, only go.mod upgrade is required. This commit is to add the capability to install new chart version without the need of releasing or installing new cilium-cli. The new chart will be downloaded and stored in user cache dir. Signed-off-by: Tam Mach <[email protected]>
sayboras
force-pushed
the
tam/dynamic-helm-version
branch
from
6f1a22c to
9262f50
Compare
kaworu
approved these changes
Sep 13, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the cilium charts are embedded inside cilium cli binary,
which will require a new cilium/charts bump in go.mod and then a new
release for cilium-cli. It's making sense to do so if some other code
changes are required to make installation working for new char version,
but most of the time, only go.mod upgrade is required.
This commit is to add the capability to install new chart version without
the need of releasing or installing new cilium-cli.
Signed-off-by: Tam Mach [email protected]
Testing
The changes are tested on top of commit 4fc8b22 (i.e. v1.13.0-rc0 is not
supported).