-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L7 HTTP method test #1069
Merged
Merged
Add L7 HTTP method test #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebril
force-pushed
the
pr/nebril/net-policies-checks
branch
from
August 30, 2022 20:06
7d87539
to
029159c
Compare
nebril
force-pushed
the
pr/nebril/net-policies-checks
branch
from
August 30, 2022 20:36
029159c
to
1efa896
Compare
nebril
force-pushed
the
pr/nebril/net-policies-checks
branch
from
August 31, 2022 10:40
1efa896
to
39dd534
Compare
This change allows to set HTTP method used for curls in PodToPod scenarios. It also allows podToPodEndpoints scenario to filter by labels like podToPod scenario. Signed-off-by: Maciej Kwiek <[email protected]>
nebril
force-pushed
the
pr/nebril/net-policies-checks
branch
from
August 31, 2022 11:31
39dd534
to
cee0eed
Compare
This change will allow creating endpoint objects based on TestPeer and retain the labels Signed-off-by: Maciej Kwiek <[email protected]>
Signed-off-by: Maciej Kwiek <[email protected]>
nebril
force-pushed
the
pr/nebril/net-policies-checks
branch
from
September 1, 2022 13:54
cee0eed
to
bbfe29e
Compare
nebril
force-pushed
the
pr/nebril/net-policies-checks
branch
from
September 1, 2022 14:00
bbfe29e
to
3982c49
Compare
This test checks whether different HTTP methods are properly handled by proxy and dropped if they don't match policy. Signed-off-by: Maciej Kwiek <[email protected]>
nebril
force-pushed
the
pr/nebril/net-policies-checks
branch
from
September 1, 2022 19:31
3982c49
to
d1d040c
Compare
sayboras
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments as per below, but not a blocker.
LGTM 💯
kind: CiliumNetworkPolicy | ||
metadata: | ||
namespace: cilium-test | ||
name: client-egress-l7-http-method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: test name could be same as policy name for faster reference (e.g. client-egress-l7-method)
tklauser
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.