Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L7 HTTP method test #1069

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Add L7 HTTP method test #1069

merged 4 commits into from
Sep 13, 2022

Conversation

nebril
Copy link
Member

@nebril nebril commented Aug 30, 2022

No description provided.

@nebril nebril requested a review from a team as a code owner August 30, 2022 20:06
@nebril nebril requested review from michi-covalent and removed request for a team August 30, 2022 20:06
@nebril nebril force-pushed the pr/nebril/net-policies-checks branch from 7d87539 to 029159c Compare August 30, 2022 20:06
@nebril nebril temporarily deployed to ci August 30, 2022 20:06 Inactive
@nebril nebril force-pushed the pr/nebril/net-policies-checks branch from 029159c to 1efa896 Compare August 30, 2022 20:36
@nebril nebril temporarily deployed to ci August 30, 2022 20:36 Inactive
@nebril nebril force-pushed the pr/nebril/net-policies-checks branch from 1efa896 to 39dd534 Compare August 31, 2022 10:40
@nebril nebril temporarily deployed to ci August 31, 2022 10:40 Inactive
This change allows to set HTTP method used for curls in PodToPod
scenarios.

It also allows podToPodEndpoints scenario to filter by labels like
podToPod scenario.

Signed-off-by: Maciej Kwiek <[email protected]>
@nebril nebril force-pushed the pr/nebril/net-policies-checks branch from 39dd534 to cee0eed Compare August 31, 2022 11:31
@nebril nebril temporarily deployed to ci August 31, 2022 11:31 Inactive
This change will allow creating endpoint objects based on TestPeer
and retain the labels

Signed-off-by: Maciej Kwiek <[email protected]>
@nebril nebril force-pushed the pr/nebril/net-policies-checks branch from cee0eed to bbfe29e Compare September 1, 2022 13:54
@nebril nebril temporarily deployed to ci September 1, 2022 13:54 Inactive
@nebril nebril force-pushed the pr/nebril/net-policies-checks branch from bbfe29e to 3982c49 Compare September 1, 2022 14:00
@nebril nebril temporarily deployed to ci September 1, 2022 14:00 Inactive
This test checks whether different HTTP methods are properly handled by
proxy and dropped if they don't match policy.

Signed-off-by: Maciej Kwiek <[email protected]>
@nebril nebril force-pushed the pr/nebril/net-policies-checks branch from 3982c49 to d1d040c Compare September 1, 2022 19:31
@nebril nebril temporarily deployed to ci September 1, 2022 19:31 Inactive
@aanm aanm requested a review from sayboras September 5, 2022 09:27
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments as per below, but not a blocker.

LGTM 💯

connectivity/tests/pod.go Show resolved Hide resolved
kind: CiliumNetworkPolicy
metadata:
namespace: cilium-test
name: client-egress-l7-http-method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: test name could be same as policy name for faster reference (e.g. client-egress-l7-method)

@tklauser tklauser merged commit f81687f into master Sep 13, 2022
@tklauser tklauser deleted the pr/nebril/net-policies-checks branch September 13, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants