Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.16.17 release regression test failure #2795

Closed
chenrui333 opened this issue Sep 14, 2024 · 7 comments · Fixed by #2803
Closed

0.16.17 release regression test failure #2795

chenrui333 opened this issue Sep 14, 2024 · 7 comments · Fixed by #2803
Assignees
@michi-covalent
Labels
kind/bug Something isn't working

Comments

@chenrui333
Copy link
Contributor

👋 seeing some regression test failure with 0.16.17 build

$ /opt/homebrew/Cellar/cilium-cli/0.16.17/bin/cilium install
strconv.ParseUint: parsing "": invalid syntax

relates to Homebrew/homebrew-core#189650
full build log, https://github.com/Homebrew/homebrew-core/actions/runs/10857969003/job/30135351920?pr=189650
@kpryu6
Copy link

kpryu6 commented Sep 15, 2024

me too

$ curl -LO https://github.com/cilium/cilium-cli/releases/download/v0.16.17/cilium-linux-arm64.tar.gz

$ sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/local/bin

$ cilium install
strconv.ParseUint: parsing "": invalid syntax

@OMikkel
Copy link

OMikkel commented Sep 18, 2024

Experiencing the same

klihub added a commit to klihub/nri-plugins that referenced this issue Sep 19, 2024
@klihub
e2e: use bridge CNI by default.
b5f3848 
Switch to using the bridge CNI plugin by default. With the latest
playbook fixes it should work now and it is the fastest to set up.
The latest cilium release is hosed, so it's a good time to switch:
  cilium/cilium-cli#2795

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub mentioned this issue Sep 19, 2024
Merged
klihub added a commit to klihub/nri-plugins that referenced this issue Sep 19, 2024
@klihub
e2e: use bridge CNI by default.
d6bc9a1 
Switch to using the bridge CNI plugin by default. With the latest
playbook fixes it should work now and it is the fastest to set up.
The latest cilium release is hosed, so it's a good time to switch:
  cilium/cilium-cli#2795

Signed-off-by: Krisztian Litkey <[email protected]>
@michi-covalent michi-covalent self-assigned this Sep 19, 2024
@michi-covalent michi-covalent added the kind/bug Something isn't working label Sep 19, 2024
michi-covalent added a commit that referenced this issue Sep 19, 2024
@michi-covalent
release: Install curl
f5b3587 
Install curl in the release make target so that CILIUM_VERSION gets set
properly.

Fixes: #2795
Fixes: #2802

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent mentioned this issue Sep 19, 2024
Merged
michi-covalent added a commit that referenced this issue Sep 19, 2024
@michi-covalent
release: Install curl
c583330 
Install curl in the release make target so that CILIUM_VERSION gets set
properly.

Fixes: #2795
Fixes: #2802

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent
Copy link
Contributor

thank you for reporting the issue. it's fixed in https://github.com/cilium/cilium-cli/releases/tag/v0.16.18 🙏

klihub added a commit to klihub/nri-plugins that referenced this issue Sep 20, 2024
@klihub
e2e: use bridge CNI by default.
16d2049 
Switch to using the bridge CNI plugin by default. With the latest
playbook fixes it should work now and it is the fastest to set up.
The latest cilium release is hosed, so it's a good time to switch:
  cilium/cilium-cli#2795

Signed-off-by: Krisztian Litkey <[email protected]>
@chenrui333
Copy link
Contributor Author

@michi-covalent
Copy link
Contributor

hmm that's strange. could you post the output from cilium version and cilium install commands? it looks like this in my env:

% cilium version
cilium-cli: v0.16.18 compiled with go1.23.1 on linux/amd64
cilium image (default): v1.16.1
cilium image (stable): v1.16.1
cilium image (running): unknown. Unable to obtain cilium version. Reason: release: not found

% cilium install
🔮 Auto-detected Kubernetes kind: kind
✨ Running "kind" validation checks
✅ Detected kind version "0.20.0"
ℹ️  Using Cilium version 1.16.1
🔮 Auto-detected cluster name: kind-kind
🔮 Auto-detected kube-proxy has been installed

@michi-covalent
Copy link
Contributor

ah i think i know what's going on. the formula needs to be updated to pass this additional flag: https://github.com/cilium/cilium-cli/blame/b4a467c5c5941c76fac6806c41cce2ea03f6c9b2/Makefile#L18

https://github.com/Homebrew/homebrew-core/blob/2b99a9f9b89b400fa793973f7b51c2c573c19f44/Formula/c/cilium-cli.rb#L29-L34

klihub added a commit to klihub/nri-plugins that referenced this issue Sep 20, 2024
@klihub
e2e: use bridge CNI by default.
c853c13 
Switch to using the bridge CNI plugin by default. With the latest
playbook fixes it should work now and it is the fastest to set up.
The latest cilium release is hosed, so it's a good time to switch:
  cilium/cilium-cli#2795

Signed-off-by: Krisztian Litkey <[email protected]>
askervin pushed a commit to containers/nri-plugins that referenced this issue Sep 20, 2024
@klihub @askervin
e2e: use bridge CNI by default.
189c8c3 
Switch to using the bridge CNI plugin by default. With the latest
playbook fixes it should work now and it is the fastest to set up.
The latest cilium release is hosed, so it's a good time to switch:
  cilium/cilium-cli#2795

Signed-off-by: Krisztian Litkey <[email protected]>
@chenrui333
Copy link
Contributor Author

I see, doing the change now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michi-covalent michi-covalent

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release: Install curl cilium/cilium-cli
4 participants
@chenrui333 @michi-covalent @OMikkel @kpryu6