Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark multicluster.yaml as required #2553

Closed
michi-covalent opened this issue May 16, 2024 · 0 comments · Fixed by #2633
Closed

mark multicluster.yaml as required #2553

michi-covalent opened this issue May 16, 2024 · 0 comments · Fixed by #2633

Comments

@michi-covalent
Copy link
Contributor

i removed multicluster.yaml from the required status check list since it's been failing a lot.

multicluster.yaml https://github.com/cilium/cilium-cli/actions/workflows/multicluster.yaml?query=branch%3Amain+event%3Aschedule++
from                to                  duration success rate
2024-05-15 21:04:04 2024-05-16 15:03:42 22m27s   🙀 25% 1/4
2024-05-14 21:03:54 2024-05-16 15:03:42 22m26s   🙀 25% 2/8
2024-05-12 21:03:41 2024-05-16 15:03:42 24m6s    🙀 38% 6/16
2024-05-08 21:03:51 2024-05-16 15:03:42 24m25s   🙀 41% 13/32
2024-04-30 21:04:32 2024-05-16 15:03:42 24m45s   🙀 42% 27/64

i chatted a bit with @giorio94 offline about how to mitigate the issue. here are some options:

i'll leave it up to @cilium/sig-clustermesh to decide how to handle this 🚀🙏

michi-covalent added a commit that referenced this issue Jun 26, 2024
Sometimes it takes a while for all the nodes to get connected to Hubble
Relay in the multicluster workflow [^1]. If Hubble is enabled, Don't
start running connectivity tests until all the nodes are connected to
avoid flow validation failures.

[^1]: https://github.com/cilium/cilium-cli/actions/runs/9664927814/job/26660784590#step:21:1456

Fixes: #2518
Fixes: #2553

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this issue Jun 26, 2024
Sometimes it takes a while for all the nodes to get connected to Hubble
Relay in the multicluster workflow [^1]. If Hubble is enabled, don't
start running connectivity tests until all the nodes are connected to
avoid flow validation failures.

[^1]: https://github.com/cilium/cilium-cli/actions/runs/9664927814/job/26660784590#step:21:1456

Fixes: #2518
Fixes: #2553

Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant