Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --wait support for cilium hubble enable #164

Closed
tgraf opened this issue Apr 14, 2021 · 3 comments · Fixed by #564
Closed

Add --wait support for cilium hubble enable #164

tgraf opened this issue Apr 14, 2021 · 3 comments · Fixed by #564
Labels
good first issue Good for newcomers

Comments

@tgraf
Copy link
Member

tgraf commented Apr 14, 2021

Similar to cilium install, cilium hubble enable should block until hubble is enabled successfully. The same Status() command can be called as is done for install.

@tgraf tgraf added the good first issue Good for newcomers label Apr 14, 2021
@stuckinforloop
Copy link

I think I can do that.

@pchaigno
Copy link
Member

@neel229 I assigned you. Don't hesitate to reach out on Slack (e.g., #development) if you have any question.

@stuckinforloop
Copy link

stuckinforloop commented Apr 17, 2021

Actually, I made a PR #169. Can someone check it out?

tklauser added a commit that referenced this issue Oct 4, 2021
By default, wait for the Relay (and UI, if `--ui` is specified)
deployments to be ready as part of enabling Hubble. This behavior can be
disabled by setting `--wait=false`.

In combination with the previous commit this allows to avoid invoking
`cilium status --wait` after enabling Hubble.

Fixes #164

Signed-off-by: Tobias Klauser <[email protected]>
tklauser added a commit that referenced this issue Oct 5, 2021
By default, wait for the Relay (and UI, if `--ui` is specified)
deployments to be ready as part of enabling Hubble. This behavior can be
disabled by setting `--wait=false`.

In combination with the previous commit this allows to avoid invoking
`cilium status --wait` after enabling Hubble.

Fixes #164

Signed-off-by: Tobias Klauser <[email protected]>
aditighag pushed a commit to aditighag/cilium-cli that referenced this issue Apr 21, 2023
By default, wait for the Relay (and UI, if `--ui` is specified)
deployments to be ready as part of enabling Hubble. This behavior can be
disabled by setting `--wait=false`.

In combination with the previous commit this allows to avoid invoking
`cilium status --wait` after enabling Hubble.

Fixes cilium#164

Signed-off-by: Tobias Klauser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants