-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --wait support for cilium hubble enable #164
Labels
good first issue
Good for newcomers
Comments
I think I can do that. |
@neel229 I assigned you. Don't hesitate to reach out on Slack (e.g., #development) if you have any question. |
Actually, I made a PR #169. Can someone check it out? |
This was referenced Oct 1, 2021
tklauser
added a commit
that referenced
this issue
Oct 4, 2021
By default, wait for the Relay (and UI, if `--ui` is specified) deployments to be ready as part of enabling Hubble. This behavior can be disabled by setting `--wait=false`. In combination with the previous commit this allows to avoid invoking `cilium status --wait` after enabling Hubble. Fixes #164 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
that referenced
this issue
Oct 5, 2021
By default, wait for the Relay (and UI, if `--ui` is specified) deployments to be ready as part of enabling Hubble. This behavior can be disabled by setting `--wait=false`. In combination with the previous commit this allows to avoid invoking `cilium status --wait` after enabling Hubble. Fixes #164 Signed-off-by: Tobias Klauser <[email protected]>
aditighag
pushed a commit
to aditighag/cilium-cli
that referenced
this issue
Apr 21, 2023
By default, wait for the Relay (and UI, if `--ui` is specified) deployments to be ready as part of enabling Hubble. This behavior can be disabled by setting `--wait=false`. In combination with the previous commit this allows to avoid invoking `cilium status --wait` after enabling Hubble. Fixes cilium#164 Signed-off-by: Tobias Klauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to
cilium install
,cilium hubble enable
should block until hubble is enabled successfully. The sameStatus()
command can be called as is done forinstall.
The text was updated successfully, but these errors were encountered: