Make file permission more explict

Replace os.Create by os.OpenFile for more granular permissions and flags. Also, adding defer function to close the file once done as per review comment. Signed-off-by: Tam Mach <[email protected]>
cilium · Jan 4, 2022 · cb34a69 · cb34a69
1 parent 041cdc1
commit cb34a69
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/internal/k8s/copy.go b/internal/k8s/copy.go
@@ -22,10 +22,11 @@ func (c *Client) CopyFromPod(ctx context.Context, namespace, pod, container stri
 		ReadFunc: readFromPod(ctx, c, namespace, pod, container, srcFile),
 	})
 
-	outFile, err := os.Create(destFile)
+	outFile, err := os.OpenFile(destFile, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
 	if err != nil {
 		return err
 	}
+	defer outFile.Close()
 
 	if _, err = io.Copy(outFile, pipe); err != nil {
 		return err