Skip to content

Commit

Permalink
helm: fix KPR autodetection value
Browse files Browse the repository at this point in the history
The logic to determine whether KPR should be enabled using the "true"
setting or the legacy "strict" one, based on the Cilium version, appears
to be inverted, apparently due to a test change which got incorrectly
committed. Let's fix it.

Fixes: ad3a82c ("helm: improve KPR autodetection logic")
Signed-off-by: Marco Iorio <[email protected]>
  • Loading branch information
giorio94 authored and tklauser committed Mar 28, 2024
1 parent ff5e187 commit 9e45f6a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion install/autodetect.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (k *K8sInstaller) autodetectKubeProxy(ctx context.Context, helmValues map[s

// Use HelmOpts to set auto kube-proxy installation
setIfUnset("kubeProxyReplacement", func() string {
if !versioncheck.MustCompile(">=1.14.0")(k.chartVersion) {
if versioncheck.MustCompile(">=1.14.0")(k.chartVersion) {
return "true"
}
return "strict"
Expand Down

0 comments on commit 9e45f6a

Please sign in to comment.