Skip to content

Commit

Permalink
Revert "suite: disable KNP tests when endpoint routes and IPv6 are en…
Browse files Browse the repository at this point in the history
…abled"

This reverts commit d2bac22.

Signed-off-by: Gilberto Bertin <[email protected]>
  • Loading branch information
jibi committed May 8, 2023
1 parent 882f25d commit 973fc91
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions connectivity/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -295,9 +295,6 @@ func Run(ctx context.Context, ct *check.ConnectivityTest) error {

// Run a simple test with k8s Network Policy.
ct.NewTest("client-ingress-knp").WithK8SPolicy(clientIngressFromClient2PolicyKNPYAML).
// disabled with endpoint routes and IPv6 until #1585 is fixed
WithFeatureRequirements(check.RequireFeatureDisabled(check.FeatureEndpointRoutes),
check.RequireFeatureDisabled(check.FeatureIPv6)).
WithScenarios(
tests.ClientToClient(),
).
Expand Down Expand Up @@ -426,9 +423,6 @@ func Run(ctx context.Context, ct *check.ConnectivityTest) error {

// This k8s policy allows ingress to echo only from client with a label 'other:client'.
ct.NewTest("echo-ingress-knp").WithK8SPolicy(echoIngressFromOtherClientPolicyKNPYAML).
// disabled with endpoint routes and IPv6 until #1585 is fixed
WithFeatureRequirements(check.RequireFeatureDisabled(check.FeatureEndpointRoutes),
check.RequireFeatureDisabled(check.FeatureIPv6)).
WithScenarios(
tests.PodToPod(),
).
Expand Down Expand Up @@ -462,9 +456,6 @@ func Run(ctx context.Context, ct *check.ConnectivityTest) error {

// This policy allows port 8080 from client to echo, so this should succeed
ct.NewTest("client-egress-knp").WithK8SPolicy(clientEgressToEchoPolicyKNPYAML).
// disabled with endpoint routes and IPv6 until #1585 is fixed
WithFeatureRequirements(check.RequireFeatureDisabled(check.FeatureEndpointRoutes),
check.RequireFeatureDisabled(check.FeatureIPv6)).
WithScenarios(
tests.PodToPod(),
)
Expand All @@ -477,9 +468,6 @@ func Run(ctx context.Context, ct *check.ConnectivityTest) error {

// This policy allows port 8080 from client to echo (using label match expression, so this should succeed
ct.NewTest("client-egress-expression-knp").WithK8SPolicy(clientEgressToEchoExpressionPolicyKNPYAML).
// disabled with endpoint routes and IPv6 until #1585 is fixed
WithFeatureRequirements(check.RequireFeatureDisabled(check.FeatureEndpointRoutes),
check.RequireFeatureDisabled(check.FeatureIPv6)).
WithScenarios(
tests.PodToPod(),
)
Expand Down

0 comments on commit 973fc91

Please sign in to comment.