test: Move pause from test to action

Move the pause on fail wait from test to action, so that nothing happens after the failed action. Signed-off-by: Jarno Rajahalme <[email protected]>
cilium · Sep 1, 2021 · 970f248 · 970f248
1 parent 89639cb
commit 970f248
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/connectivity/check/action.go b/connectivity/check/action.go
@@ -157,6 +157,10 @@ func (a *Action) Run(f func(*Action)) {
 		a.printFlows(a.Source())
 		a.printFlows(a.Destination())
 	}
+	if a.failed && a.test.ctx.params.PauseOnFail {
+		a.Log("Pausing after action failure, press the Enter key to continue:")
+		fmt.Scanln()
+	}
 }
 
 // fail marks the Action as failed.

diff --git a/connectivity/check/test.go b/connectivity/check/test.go
@@ -109,11 +109,6 @@ func (t *Test) willRun() bool {
 // finalize runs all the Test's registered finalizers.
 // Failures encountered executing finalizers will fail the Test.
 func (t *Test) finalize() {
-	if t.failed && t.Context().params.PauseOnFail {
-		t.Log("Pausing after test failure, press the Enter key to continue:")
-		fmt.Scanln()
-	}
-
 	t.Debug("Finalizing Test", t.Name())
 
 	for _, f := range t.finalizers {