introduce --open-browser flag on cilium hubble UI

Signed-off-by: zufardhiyaulhaq <[email protected]>

hubble/hubble.go

@@ -136,6 +136,9 @@ type Parameters struct {
 
 	// RedactHelmCertKeys does not print helm certificate keys into the terminal.
 	RedactHelmCertKeys bool
+
+	// UIOpenBrowser will automatically open browser if true
+	UIOpenBrowser bool
 }
 
 func (p *Parameters) Log(format string, a ...interface{}) {

hubble/ui.go

@@ -247,11 +247,15 @@ func (p *Parameters) UIPortForwardCommand(ctx context.Context) error {
 		time.Sleep(5 * time.Second)
 		url := fmt.Sprintf("http://localhost:%d", p.UIPortForward)
 
-		// avoid cluttering stdout/stderr when opening the browser
-		browser.Stdout = io.Discard
-		browser.Stderr = io.Discard
-		p.Log("ℹ️  Opening %q in your browser...", url)
-		browser.OpenURL(url)
+		if p.UIOpenBrowser {
+			// avoid cluttering stdout/stderr when opening the browser
+			browser.Stdout = io.Discard
+			browser.Stderr = io.Discard
+			p.Log("ℹ️  Opening %q in your browser...", url)
+			browser.OpenURL(url)
+		} else {
+			p.Log("ℹ️  Hubble UI is available at %q", url)
+		}
 	}()
 
 	_, err := utils.Exec(p, "kubectl", args...)

internal/cli/cmd/hubble.go

@@ -175,6 +175,7 @@ func newCmdUI() *cobra.Command {
 	}
 
 	cmd.Flags().IntVar(&params.UIPortForward, "port-forward", 12000, "Local port to use for the port forward")
+	cmd.Flags().BoolVar(&params.UIOpenBrowser, "open-browser", true, "When --open-browser=false is supplied, cilium Hubble UI will not open the browser")
 
 	return cmd
 }