test: Move pause from test to action

Move the pause on fail wait from test to action, so that nothing happens after the failed action. Signed-off-by: Jarno Rajahalme <[email protected]>
cilium · Jun 16, 2021 · 3af4421 · 3af4421
1 parent 39ac4f2
commit 3af4421
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/connectivity/check/action.go b/connectivity/check/action.go
@@ -136,6 +136,10 @@ func (a *Action) Run(f func(*Action)) {
 			a.printFlows(name, flows, a.flowResults[name])
 		}
 	}
+	if a.failed && a.test.ctx.params.PauseOnFail {
+		a.Log("Pausing after test case failure, press the Enter key to continue:")
+		fmt.Scanln()
+	}
 }
 
 // fail marks the Action as failed.

diff --git a/connectivity/check/test.go b/connectivity/check/test.go
@@ -124,11 +124,6 @@ func (t *Test) willRun() bool {
 // Failures encountered executing finalizers will be raised as warnings
 // against the Test.
 func (t *Test) finalize() {
-	if t.failed && t.Context().params.PauseOnFail {
-		t.Log("Pausing after test failure, press the Enter key to continue:")
-		fmt.Scanln()
-	}
-
 	t.Debug("Finalizing Test", t.Name())
 
 	for _, f := range t.finalizers {