Move OutputJSON and OutputSummary to status package

Signed-off-by: Raphaël Pinson <[email protected]>
cilium · Feb 6, 2023 · 2cad140 · 2cad140
1 parent a98d358
commit 2cad140
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/clustermesh/clustermesh.go b/clustermesh/clustermesh.go
@@ -474,11 +474,6 @@ type Parameters struct {
 	Output               string
 }
 
-const (
-	OutputJSON    = "json"
-	OutputSummary = "summary"
-)
-
 func (p Parameters) validateParams() error {
 	if p.ApiserverImage != defaults.ClusterMeshApiserverImage {
 		return nil
@@ -505,7 +500,7 @@ func NewK8sClusterMesh(client k8sClusterMeshImplementation, p Parameters) *K8sCl
 }
 
 func (k *K8sClusterMesh) Log(format string, a ...interface{}) {
-	if k.params.Output == OutputSummary {
+	if k.params.Output == status.OutputSummary {
 		fmt.Fprintf(k.params.Writer, format+"\n", a...)
 	}
 }
@@ -1312,7 +1307,7 @@ func (k *K8sClusterMesh) Status(ctx context.Context) (*Status, error) {
 
 	s.Connectivity, err = k.statusConnectivity(ctx)
 
-	if k.params.Output == OutputJSON {
+	if k.params.Output == status.OutputJSON {
 		jsonStatus, err := json.MarshalIndent(s, "", " ")
 		if err != nil {
 			return nil, fmt.Errorf("failed to marshal status to JSON")

diff --git a/internal/cli/cmd/clustermesh.go b/internal/cli/cmd/clustermesh.go
@@ -15,6 +15,7 @@ import (
 
 	"github.com/cilium/cilium-cli/clustermesh"
 	"github.com/cilium/cilium-cli/defaults"
+	"github.com/cilium/cilium-cli/status"
 )
 
 func newCmdClusterMesh() *cobra.Command {

diff --git a/internal/cli/cmd/status.go b/internal/cli/cmd/status.go
@@ -35,7 +35,7 @@ func newCmdStatus() *cobra.Command {
 				fmt.Print(s.Format())
 				fatalf("Unable to determine status:  %s", err)
 			}
-			if params.Output == "json" {
+			if params.Output == status.OutputJSON {
 				jsonStatus, err := json.MarshalIndent(s, "", " ")
 				if err != nil {
 					// Report the most recent status even if an error occurred.
@@ -55,7 +55,7 @@ func newCmdStatus() *cobra.Command {
 	cmd.Flags().IntVar(&params.WorkerCount,
 		"worker-count", status.DefaultWorkerCount,
 		"The number of workers to use")
-	cmd.Flags().StringVarP(&params.Output, "output", "o", "summary", "Output format. One of: json, summary")
+	cmd.Flags().StringVarP(&params.Output, "output", "o", status.OutputSummary, "Output format. One of: json, summary")
 
 	return cmd
 }
diff --git a/status/status.go b/status/status.go
@@ -26,6 +26,11 @@ const (
 	Reset   = "\033[0m"
 )
 
+const (
+	OutputJSON    = "json"
+	OutputSummary = "summary"
+)
+
 // MapCount is a map to count number of occurrences of a string
 type MapCount map[string]int