helm: Rename newChartFromCiliumVersion function

This commit is to rename newChartFromCiliumVersion function to newChartFromEmbeddedFile. Signed-off-by: Tam Mach <[email protected]>
cilium · Sep 19, 2022 · 29981e6 · 29981e6
1 parent 6453c72
commit 29981e6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/internal/helm/helm.go b/internal/helm/helm.go
@@ -183,7 +183,7 @@ func newClient(namespace, k8sVersion string) (*action.Install, error) {
 	return helmClient, nil
 }
 
-func newChartFromCiliumVersion(ciliumVersion semver2.Version) (*chart.Chart, error) {
+func newChartFromEmbeddedFile(ciliumVersion semver2.Version) (*chart.Chart, error) {
 	helmTgz, err := helm.HelmFS.ReadFile(fmt.Sprintf("cilium-%s.tgz", ciliumVersion))
 	if err != nil {
 		return nil, fmt.Errorf("cilium version not found: %s", err)
@@ -216,7 +216,7 @@ func GenManifests(
 			return nil, err
 		}
 	} else {
-		helmChart, err = newChartFromCiliumVersion(ciliumVer)
+		helmChart, err = newChartFromEmbeddedFile(ciliumVer)
 		if err != nil {
 			return nil, err
 		}
@@ -332,7 +332,7 @@ func ResolveHelmChartVersion(versionFlag, chartDirectoryFlag string) (semver2.Ve
 		if err != nil {
 			return semver2.Version{}, err
 		}
-		if _, err = newChartFromCiliumVersion(version); err != nil {
+		if _, err = newChartFromEmbeddedFile(version); err != nil {
 			return semver2.Version{}, err
 		}
 		return version, nil