unit test: Restore the original env variable using defer

Fixes: 840b570 ("Add a function to check if the CLI is in Helm mode") Signed-off-by: Michi Mutsuzaki <[email protected]>
cilium · May 10, 2023 · 1d110cc · 1d110cc
1 parent 148f953
commit 1d110cc
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/utils/utils_test.go b/internal/utils/utils_test.go
@@ -208,11 +208,13 @@ func TestBuildImagePath(t *testing.T) {
 
 func TestIsInHelmMode(t *testing.T) {
 	orig := os.Getenv(CLIModeVariableName)
+	defer func() {
+		assert.NoError(t, os.Setenv(CLIModeVariableName, orig))
+	}()
 	assert.NoError(t, os.Setenv(CLIModeVariableName, "helm"))
 	assert.True(t, IsInHelmMode())
 	assert.NoError(t, os.Setenv(CLIModeVariableName, "classic"))
 	assert.False(t, IsInHelmMode())
 	assert.NoError(t, os.Setenv(CLIModeVariableName, "random"))
 	assert.False(t, IsInHelmMode())
-	assert.NoError(t, os.Setenv(CLIModeVariableName, orig))
 }