Correctly specify the chart version to pull #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/struggle
branch
2 times, most recently
from
351ccb4 to
9fc85d2
Compare
|
✅ tested the fix: https://github.com/cilium/charts/actions/runs/9294015763/job/25578328654?pr=126 marking it ready for review 🚀 🙏 |
michi-covalent
force-pushed
the
pr/michi/struggle
branch
from
9fc85d2 to
55130ac
Compare
There is no ${{ steps.vars.outputs.chartVersion }}. Also create the tmp
directory before running helm pull.
Fixes: 3a7f889 ("Validate Helm chart")
Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/struggle
branch
from
55130ac to
78cd192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no ${{ steps.vars.outputs.chartVersion }}. Also create the tmp directory before running helm pull.
Fixes: 3a7f889 ("Validate Helm chart")