Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unihan Revision 37 #330

Merged
merged 17 commits into from
Nov 25, 2024
Merged

Unihan Revision 37 #330

merged 17 commits into from
Nov 25, 2024

Conversation

tony
Copy link
Member

@tony tony commented Nov 25, 2024 •
edited
Loading

Changes

Revision 37 updates

These changes align with Unicode Technical Report #38's 37th revision and are part of ongoing improvements to Unihan data handling.

Add kFanqie and kZhuang

Adds support for the kFanqie and kZhuang fields.

See also:

Support kRSUnicode for apostrophes

Unihan_IRGSources: Updated kRSUnicode for apostrophes.

See also:

Removals

  • kFrequency: Removed from Unihan_DictionaryLikeData, constants, and datapackage.json.

See also:

Tests

  • Added tests for simplified expansions to ensure correctness of kFanqie and kZhuang.

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.75676% with 16 lines in your changes missing coverage. Please review.

Project coverage is 66.95%. Comparing base (31a8a79) to head (099ae5a).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/unihan_etl/expansion.py 54.54% 15 Missing ⚠️
tests/test_expansion.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   67.19%   66.95%   -0.25%     
==========================================
  Files          12       12              
  Lines        1256     1292      +36     
  Branches      231      238       +7     
==========================================
+ Hits          844      865      +21     
- Misses        356      370      +14     
- Partials       56       57       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tony added 5 commits November 25, 2024 11:50
@tony
Unihan_Readings: Add kFanqie
3fc8009 
See also:
- https://www.unicode.org/reports/tr38/#kFanqie
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
Unihan_Readings: Add kZhuang
bfde466 
See also:
- https://www.unicode.org/reports/tr38/#kZhuang
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
data(Unihan_DictionaryLikeData) Remove kFrequency
e7fae15 
See also:
- https://www.unicode.org/L2/L2024/24006.htm#178-C17
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
datapackage.json: Remove kFrequency
7e9b39d 
See also:
- https://www.unicode.org/L2/L2024/24006.htm#178-C17
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
constants(Unihan_DictionaryLikeData) Remove kFrequency
f399425 
See also:
- https://www.unicode.org/L2/L2024/24006.htm#178-C17
- https://www.unicode.org/reports/tr38/#ChronologicalListing
tony added 5 commits November 25, 2024 11:51
@tony
datapackage.json: Add kFanqie
6452865 
See also:
- https://www.unicode.org/reports/tr38/#kFanqie
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
datapackage.json: Add kZhuang
bd31390 
See also:
- https://www.unicode.org/reports/tr38/#kZhuang
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
constants(Unihan_Readings) Add kFanqie
8c324de 
See also:
- https://www.unicode.org/reports/tr38/#kFanqie
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
constants(Unihan_Readings) Add kZhuang
6ec5b06 
See also:
- https://www.unicode.org/reports/tr38/#kZhuang
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
data(Unihan_IRGSources) Update kRSUnicode for apostrophes
7c01d41 
See also:
- #318
- #315 (comment)
- https://www.unicode.org/reports/tr38/tr38-36.html#kRSUnicode
- https://www.unicode.org/L2/L2024/24006.htm#178-C17
- https://www.unicode.org/reports/tr38/#ChronologicalListing
tony added 6 commits November 25, 2024 13:19
@tony
constants(SPACE_DELIMITED_LIST_FIELDS) Add kFanqie for expansion
018f74f 
See also:
- https://www.unicode.org/reports/tr38/#kFanqie
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
constants(SPACE_DELIMITED_LIST_FIELDS) Add kZhuang for expansion
4baa1ca 
See also:
- https://www.unicode.org/reports/tr38/#kZhuang
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
tests(expansion) Test simplified expansions
de99012
@tony
expansion: Add kFanqie for expansion
fec83f9 
See also:
- https://www.unicode.org/reports/tr38/#kFanqie
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
expansion: Add kZhuang for expansion
54d1b62 
See also:
- https://www.unicode.org/reports/tr38/#kZhuang
- https://www.unicode.org/reports/tr38/#ChronologicalListing
@tony
docs(CHANGES) Note Revision 37 updates
099ae5a
@tony tony merged commit 84e6972 into master Nov 25, 2024
13 checks passed
@tony tony deleted the revision-37 branch November 25, 2024 20:38
@tony tony mentioned this pull request Nov 25, 2024
Merged
tony added a commit to cihai/unihan-db that referenced this pull request Nov 25, 2024
@tony
Unihan: Revision 37 support, unihan v0.35.0 (#345)
528fbdc 
# Changes

## unihan-etl: 0.34.0 -> 0.35.0

See also:
- https://github.com/cihai/unihan-etl/blob/v0.35.0/CHANGES
- https://unihan-etl.git-pull.com/history.html#unihan-etl-0-35-0-2024-11-25

## Removed `kFrequency`

See https://www.unicode.org/L2/L2024/24006.htm#178-C17.

## Update `kRSUnicode`

Updated for additional simplified formats (`kRSSimplifiedType`)

# See also

- cihai/unihan-etl#330
- UNIHAN Revision 37: https://www.unicode.org/reports/tr38/tr38-37.html#Modifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tony