Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ember-cli 2.12.3 #128

Merged
merged 5 commits into from
Jul 13, 2017

Conversation

notmessenger
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Upgrade to ember-cli 2.12.3

@notmessenger notmessenger requested a review from juwara0 July 12, 2017 21:35
/* global require, module */
var EmberApp = require('ember-cli/lib/broccoli/ember-addon')
/* eslint-env node */
var EmberAddon = require('ember-cli/lib/broccoli/ember-addon')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be const

@juwara0
Copy link
Contributor

juwara0 commented Jul 13, 2017

Approved

Approved with PullApprove

@notmessenger notmessenger merged commit 79e9708 into ciena-frost:master Jul 13, 2017
@notmessenger notmessenger deleted the ember-cli-2.12.3 branch July 13, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants