Upgrade Ember CLI 2.16.2 #503

juwara0 · 2017-10-17T20:24:37Z

This project uses semver, please check the scope of this pr:

#none# - documentation fixes and/or test additions
#patch# - backwards-compatible bug fix
#minor# - adding functionality in a backwards-compatible manner
#major# - incompatible API change

CHANGELOG

Updated testing dependencies
Updated to Ember CLI 2.16.2 and babel 6
Updated to using ember-decorators which replaces ember-computed-decorators
Updated dependencies
Updated pr-bumber to version 3
Updated CONTRIBUTING.md file
Updated to using Ember Javascript Modules API https://github.com/ember-cli/ember-rfc176-data
Updated blueprints to latest versions of dependencies
Updated to use chrome headless in Travis CI
Updated to using Node 8.1.2 NPM 5
Added eslint-plugin-ember to enforce Ember Javascript Modules API syntax
Removed running of code coverage until issue is resolved with ember-cli-code-coverage: Issues with ember-cli-htmlbars-inline-precompile 1.0 ember-cli-code-coverage/ember-cli-code-coverage#133
Removed running of ember-try its-2.12 scenario until issue is resolved: Travis and yarn issue on Ember 2.12 only ember-cli/ember-try#148
Updated blueprint helper tests to be commented out since in babel 6 CommonJS files are converted to AMD (which needs import of require) and then being transpiled.

…our needs

…ax in imports

…Ember CLI 2.16.x

…abel 6

into upgradeEmberCli_2-16-2

…avis.yml

…s currently broken

ember-cli/ember-try#148

notmessenger · 2017-10-18T14:10:10Z

addon/components/frost-select-dropdown.js

@@ -523,7 +529,7 @@ export default Component.extend({

        case TAB:
          this.get('onClose')()
-          return
+          return // eslint-disable-line no-useless-return


Remove the return

I will open an issue for us to refactor this code

Issue opened to track this: #506

notmessenger · 2017-10-18T14:17:43Z

tests/dummy/app/pods/components/demo-palette/component.js

@@ -1,6 +1,5 @@
 /* global $ */


Remove and import from jquery?

notmessenger · 2017-10-18T14:19:54Z

tests/helpers/module-for-acceptance.js

@@ -0,0 +1,21 @@
+import destroyApp from '../helpers/destroy-app'


Don't need this file, right?

notmessenger · 2017-10-18T14:21:06Z

tests/unit/components/frost-radio-button-test.js

@@ -14,14 +13,14 @@ describe(test.label, function () {
  beforeEach(function () {
    component = this.subject({
      _setupAssertions: function () {
-        return
+        return // eslint-disable-line no-useless-return


Remove the return

notmessenger · 2017-10-18T14:21:35Z

tests/unit/components/frost-scroll-test.js

    const spyOn = sinon.spy($.fn, 'on')
    const spyOff = sinon.spy($.fn, 'off')

-    component.set('onScrollUp', function () { return })
+    component.set('onScrollUp', function () { return }) // eslint-disable-line no-useless-return


Remove the return

notmessenger · 2017-10-18T14:23:29Z

tests/unit/components/frost-scroll-test.js

    const spyOn = sinon.spy($.fn, 'on')
    const spyOff = sinon.spy($.fn, 'off')

-    component.set('onScrollLeft', function () { return })
+    component.set('onScrollLeft', function () { return }) // eslint-disable-line no-useless-return


Remove the return

notmessenger · 2017-10-18T14:23:54Z

tests/unit/components/frost-scroll-test.js

    const spyOn = sinon.spy($.fn, 'on')
    const spyOff = sinon.spy($.fn, 'off')

-    component.set('onMouseEnter', function () { return })
+    component.set('onMouseEnter', function () { return }) // eslint-disable-line no-useless-return


Remove the return

notmessenger · 2017-10-18T14:24:18Z

tests/unit/components/frost-scroll-test.js

    const spyOn = sinon.spy($.fn, 'on')
    const spyOff = sinon.spy($.fn, 'off')

-    component.set('onScrollRight', function () { return })
+    component.set('onScrollRight', function () { return }) // eslint-disable-line no-useless-return


Remove the return

notmessenger · 2017-10-18T14:25:17Z

tests/unit/lib/utils/consumer.js

@@ -1,19 +1,19 @@
-const consumer = require('../../../../lib/utils/consumer')
-const expect = require('chai').expect
+// const consumer = require('../../../../lib/utils/consumer')


Get rid of the file instead of commenting out? Or use .skip()?

notmessenger · 2017-10-18T14:26:22Z

tests/unit/lib/utils/npm.js

-    })
-  })
-})
+// const expect = require('chai').expect


Get rid of the file instead of commenting out? Or use .skip()?

notmessenger · 2017-10-18T14:54:24Z

👍

juwara0 · 2017-10-18T15:53:38Z

It was necessary to temporarily not run ember-try scenario ember-lts-2.12 due to an issue in CI. An issue was opened to track this: #505

…li_2-16-2" This reverts commit 5e8bcad, reversing changes made to e1255c0.

juwara0 added 30 commits September 20, 2017 14:52

upgrade to Ember CLI 2.15.1

7a9bce9

update babel config and plugins to support decorator syntax for babel6

ada3a71

update to Ember CLI 2.15.1 version of interdependencies

5c2ccbc

update to using main broccoli-svgstore since it has been updated per …

18624a4

…our needs

update broccoli-autoprefixer version

53e5b02

update broccoli-funnel dependency

a144bda

update broccoli-merge-trees dependency

c4ad373

update chalk dependency

599eed5

updated promise dependency

688e9cf

update version of ember-cli-sass

ce34e32

remove frost-guide-custom-routing dependency

ff5868d

updated CONTRIBUTING.md

aa3d8c8

update version of ember-elsewhere

f42c755

update ember-concurrency version

62213cf

migrate to using Ember Javascript Module API syntax for imports

7316330

add eslint rule to enforce usage of Ember Javascript Modules API synt…

8c6f6c4

…ax in imports

migrate test helpers to addon-test-support

2780e1d

update dependencies in blueprints

dc0aa75

migrate from ember-computed-decorators to ember-decorators

bb73783

update ember-test-utils to pull in latest lint and fix linting

c05b230

remove running of node blueprint-helper tests

b23ae40

update pr-bumber to version 2

741b03a

disable code coverage until issue with babel transpilation is solved

6d720f0

ignore linting of CHANGELOG

ee0e1af

upgrade to Ember CLI 2.16.1

bd76975

remove babel-plugin-ember-modules-api-polyfill since now included in …

60ea4f0

…Ember CLI 2.16.x

update ember-data to 2.16.x

64d98cc

update blueprints to latest versions of dependencies

a5eada7

update to Ember CLI 2.16.2

069d120

update ember-cli-chai

cc6a525

juwara0 added 5 commits October 17, 2017 11:41

removed need to transpile differently since addon now only supports b…

400c34c

…abel 6

update ember-truth-helpers to latest version

61b6c32

update to pr-bumper version 3 and node 8.1.2

ea8b6bf

create package-lock with latest versions of packages

ca0b771

remove extra spaces inside import braces

781a3fe

juwara0 assigned notmessenger Oct 17, 2017

juwara0 added 10 commits October 17, 2017 15:25

Merge branch 'master' of https://github.com/ciena-frost/ember-frost-core

8cb43fa

into upgradeEmberCli_2-16-2

add bower install command to travis.yml

4a52a2b

change sudo back to required and remove bower install command from tr…

2e3eeac

…avis.yml

add npm install and bower install since pr-bumper script is not working

1c2feab

add global install of bower to travis.yml

42a1103

added two missing files created as a result of runnign ember init

f77c420

removing running of maybe-check-coverage script since code coverage i…

402c833

…s currently broken

remove npm install and bower install commands added for debugging

89efca6

adding npm install and bower install commands back to CI

e8892f8

Remove running of ember-try ember-LTS-2.12 scenario until issue resolved

c01dcaa

ember-cli/ember-try#148

notmessenger suggested changes Oct 18, 2017

View reviewed changes

notmessenger approved these changes Oct 18, 2017

View reviewed changes

fixes requested during code review

b94d42b

juwara0 merged commit 5e8bcad into ciena-frost:master Oct 18, 2017

juwara0 deleted the upgradeEmberCli_2-16-2 branch October 18, 2017 15:13

notmessenger mentioned this pull request Oct 19, 2017

Upgrade to Ember CLI 2.16.2 ciena-frost/ember-frost-info-bar#78

Merged

4 tasks

notmessenger added a commit to notmessenger/ember-frost-core that referenced this pull request Nov 2, 2017

Revert "Merge pull request ciena-frost#503 from juwara0/upgradeEmberC…

8e1cb0c

…li_2-16-2" This reverts commit 5e8bcad, reversing changes made to e1255c0.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Ember CLI 2.16.2 #503

Upgrade Ember CLI 2.16.2 #503

juwara0 commented Oct 17, 2017 •

edited

Loading

notmessenger Oct 18, 2017

juwara0 Oct 18, 2017

juwara0 Oct 18, 2017

notmessenger Oct 18, 2017

juwara0 Oct 18, 2017

notmessenger Oct 18, 2017

juwara0 Oct 18, 2017

notmessenger Oct 18, 2017

juwara0 Oct 18, 2017

notmessenger Oct 18, 2017

juwara0 Oct 18, 2017

notmessenger Oct 18, 2017

juwara0 Oct 18, 2017

notmessenger Oct 18, 2017

juwara0 Oct 18, 2017

notmessenger Oct 18, 2017

juwara0 Oct 18, 2017

notmessenger Oct 18, 2017

notmessenger Oct 18, 2017

notmessenger commented Oct 18, 2017 •

edited by cstolli

Loading

juwara0 commented Oct 18, 2017

		@@ -0,0 +1,21 @@
		import destroyApp from '../helpers/destroy-app'

Upgrade Ember CLI 2.16.2 #503

Upgrade Ember CLI 2.16.2 #503

Conversation

juwara0 commented Oct 17, 2017 • edited Loading

CHANGELOG

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

notmessenger commented Oct 18, 2017 • edited by cstolli Loading

juwara0 commented Oct 18, 2017

juwara0 commented Oct 17, 2017 •

edited

Loading

notmessenger commented Oct 18, 2017 •

edited by cstolli

Loading