Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

507 add reference lines to trajectory plot #521

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

marjoleinpnnl
Copy link
Contributor

No description provided.

@marjoleinpnnl marjoleinpnnl linked an issue Mar 7, 2024 that may be closed by this pull request
Copy link
Contributor

@JosephCottam JosephCottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the schema, it would be nice if the horizontal and vertical markers used the same naming convention. One is "_markers_v" the other is "_hmarkers". Please make that consistent.

@JosephCottam JosephCottam merged commit e041922 into main Mar 13, 2024
5 checks passed
@JosephCottam JosephCottam deleted the 507-add-reference-lines-to-trajectory-plot branch March 13, 2024 23:39
sabinala pushed a commit that referenced this pull request Mar 14, 2024
* add trajectory horizonal to vg file
* add markers to test
* update trajectory plot
* correcting names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reference line(s) to trajectory plot
2 participants