Fix BeforeOptions
search input missing aria-expanded
#1716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The search input in
BeforeOptions
has arole="combobox"
which requires an "aria-expanded" attribute (set to "true" or "false") depending on the state.Generally, the
BeforeOptions
is only visible when the PowerSelect is expanded, but since we have access to its state we can use@select.isOpen
to conditionally apply this value.Example
The example below uses the
helpers-testing-single-power-select
instance in thetest-app
with either a@labelText="Label"
or an@ariaLabel="Label"
provided to the<PowerSelect>
.Automated accessibility checks using axe
Motivation
At @hashicorp we use
<PowerSelect>
extensively and we are grateful to see the many improvements introduced lately.This change is primarily motivated by the desire to further improve the accessibility compliance of this component – in this instance, by providing the required aria attribute for the combobox element.