isSliceable is not working for ember data 3.x hasmany relationships #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t least for 3.27.X This commit removed ember-data array deprecations, but introduced a bug for ED 3.27.X users. HasMany relationships donn't impement .sort, I think the idea is just to finnd out if the thing we are dealing with is an Arrayish, I would favor isArray util... which takes into account other ember array like things cibernox@83720b4
betocantu93
changed the title
betocantu93
changed the title
mkszepp
changed the title
|
Thank you for reporting! Yes i think this should fix the problem bug with ember-data 3.x. For ember-data 4.x & ember 5 there should no side effects. I think we should add a test with ember-data for 3.28, while we support this old LTS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit 83720b4 introduced a bug for ED 3.27.X users (or earlier versions I guess, idk). HasMany relationships don't implement
.sort, I think the idea is just to find out if the thing we are dealing with is an Arrayish, I would favor isArray util... which takes into account other ember array-like things