Implement all role & aria properties in RFC #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See cibernox/ember-power-select#293 (comment) - [x] `role=button` - [x] `aria-haspopup=true` tells AT to treat the trigger as a host for conditional content - [x] `aria-expanded=true/false` tells AT that conditional content is expanded - [x] `aria-pressed=true/false` tells AT that the `button` is in a pressed or 'true' state (technically different from whether the conditional content is expanded, but in practice usually the same). - [x] `aria-controls=<id of dropdown>` is all we need since there is no requirement that the trigger element own or have a direct DOM relationship to the dropdown
cibernox
added a commit
that referenced
this pull request
Feb 10, 2016
…ibutes Implement all role & aria properties in RFC
|
Woo! 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cibernox/ember-power-select#293 (comment)
role=buttonaria-haspopup=truetells AT to treat the trigger as a host for conditional contentaria-expanded=true/falsetells AT that conditional content is expandedaria-pressed=true/falsetells AT that thebuttonis in a pressed or 'true' state (technically different from whether the conditional content is expanded, but in practice usually the same).aria-controls=<id of dropdown>is all we need since there is no requirement that the trigger element own or have a direct DOM relationship to the dropdown