Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change of color (ANSI color code unchaged) when calling log.SetOutput(l.Stderr()) #216

Open
gekigek99 opened this issue Dec 26, 2022 · 4 comments

Comments

@gekigek99
Copy link

example code:

package main

import (
	"fmt"
	"io"
	"log"
	"os"
	"time"

	"github.com/chzyer/readline"
)

const (
	COLOR_RESET = "\033[0m"
	COLOR_GREEN = "\033[32m"
)

func main() {
	go logger()

	time.Sleep(2 * time.Second)

	fmt.Println("calling log.SetOutput() inside GetInput() which changes color")
	go GetInput()

	time.Sleep(time.Hour)
}

func logger() {
	for {
		log.Printf("%scolor%s\n", COLOR_GREEN, COLOR_RESET)
		time.Sleep(500 * time.Millisecond)
	}
}

// GetInput is used to read input from user.
// [goroutine]
func GetInput() {
	l, err := readline.NewEx(
		&readline.Config{
			Prompt: "» ",
			AutoComplete: readline.NewPrefixCompleter(
				readline.PcItem("msh",
					readline.PcItem("start"),
					readline.PcItem("freeze"),
					readline.PcItem("exit"),
				),
				readline.PcItem("mine"),
			),
			FuncFilterInputRune: func(r rune) (rune, bool) {
				switch r {
				case readline.CharCtrlZ: // block CtrlZ feature
					return r, false
				}
				return r, true
			},
		})
	if err != nil {
		fmt.Println("error while starting readline: %s", err.Error())
		return
	}
	defer l.Close()

	log.SetOutput(l.Stderr()) // autorefresh prompt line
	for {
		line, err := l.Readline()
		switch err {
		case nil:
		case io.EOF, readline.ErrInterrupt:
			os.Exit(1)
		default:
			fmt.Println(err.Error())
			continue
		}

		fmt.Println("user input: %s", line)
	}
}

powershell && cmd

first 4 are dark green, last 4 are light green

2022/12/26 19:00:32 color
2022/12/26 19:00:32 color
2022/12/26 19:00:33 color
2022/12/26 19:00:34 color
calling log.SetOutput() inside GetInput() which changes color
2022/12/26 19:00:34 color
2022/12/26 19:00:35 color
2022/12/26 19:00:35 color
2022/12/26 19:00:36 color

git bash

2022/12/26 19:05:44 ←[32mcolor←[0m
2022/12/26 19:05:45 ←[32mcolor←[0m
2022/12/26 19:05:45 ←[32mcolor←[0m
2022/12/26 19:05:46 ←[32mcolor←[0m
calling log.SetOutput() inside GetInput() which changes color
2022/12/26 19:05:46 color
2022/12/26 19:05:47 color
2022/12/26 19:05:47 color
2022/12/26 19:05:48 color

specs

  • windows 10
  • amd64
  • using vscode

question

  • what can I use instead of log.SetOutput(l.Stderr()) to autorefresh the prompt line and having it always at the bottom?
  • is it correct to use log.SetOutput(l.Stdout())?
  • what can I do to avoid the unwanted color change?
@slingamn
Copy link
Collaborator

slingamn commented Feb 8, 2023

@gekigek99 I'm curious if #218 would work for you?

@gekigek99
Copy link
Author

It's a possibility, how can i test it?

(I mean how can I install a specific branch of a library?)

@slingamn
Copy link
Collaborator

slingamn commented Feb 8, 2023

Probably the easiest technique:

  1. Fetch this PR and check it out locally. (If you already have a clone of this repository you can git fetch origin pull/218/head and then git checkout FETCH_HEAD.)
  2. Use go mod replace to repoint at your local checkout: https://thewebivore.com/using-replace-in-go-mod-to-point-to-your-local-module/

edit: fix reference to PR number

@gekigek99
Copy link
Author

#218 indeed solves it!

great job @slingamn! I don't think I ever saw a faster fix ;)

Btw I love your philosophy rep <3

gekigek99 added a commit to gekware/minecraft-server-hibernation that referenced this issue Feb 12, 2023
bugfix errco color change (ANSI color code unchaged)
chzyer/readline#216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants