Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sql action karim #221

Closed
wants to merge 2 commits into from
Closed

Feat/sql action karim #221

wants to merge 2 commits into from

Conversation

KarimGl
Copy link
Contributor

@KarimGl KarimGl commented Nov 21, 2024

Issue Number

fixes #

Describe the changes you've made

  • Sql client can habndle blob
  • test it on h2 and oracle

Describe if there is any unusual behaviour of your code

Additional context

Test plan

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@KarimGl KarimGl force-pushed the feat/sql_action_karim branch from bd95a83 to 603d4f1 Compare November 21, 2024 13:15
@KarimGl KarimGl closed this Nov 21, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.25%. Comparing base (d3db2ec) to head (603d4f1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../com/chutneytesting/action/sql/core/SqlClient.java 73.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #221      +/-   ##
============================================
+ Coverage     60.94%   61.25%   +0.30%     
- Complexity     3361     3416      +55     
============================================
  Files           662      668       +6     
  Lines         18266    18492     +226     
  Branches       1005     1012       +7     
============================================
+ Hits          11133    11328     +195     
- Misses         6729     6757      +28     
- Partials        404      407       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants