Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/zip #208

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Feat/zip #208

merged 7 commits into from
Nov 18, 2024

Conversation

KarimGl
Copy link
Contributor

@KarimGl KarimGl commented Oct 25, 2024

Issue Number

fixes #

Describe the changes you've made

  • change report column type to blob (h2) and BYTEA(postgres) and keep string for sqlite
  • Data is indexed using lucene in file a system directory (path: ${chutney.index-folder:~/.chutney/index})
  • One shot migration: compress existing exec reports by step of 10
  • Do gzip<->string migration when reading/writing exec report using jakarta.persistence.AttributeConverter
  • add to / remove from index when saving/removing report exec db entity using AOP
  • remove reportfrom index when deactivate scenario
  • Full text search in report fetch data from index
  • ❌ add junit test for IndexingAspect.
  • Integration tests for indexing are already verified in ScenarioExecutionReportMatch for example

Describe if there is any unusual behaviour of your code

Additional context

Test plan

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 82.31707% with 29 lines in your changes missing coverage. Please review.

Project coverage is 61.13%. Comparing base (d3db2ec) to head (bd612b0).

Files with missing lines Patch % Lines
.../execution/infra/migration/ZipReportMigration.java 68.57% 8 Missing and 3 partials ⚠️
...om/chutneytesting/index/infra/IndexRepository.java 77.50% 9 Missing ⚠️
...g/execution/infra/storage/jpa/ReportConverter.java 65.00% 5 Missing and 2 partials ⚠️
.../chutneytesting/index/infra/OnDiskIndexConfig.java 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #208      +/-   ##
============================================
+ Coverage     60.94%   61.13%   +0.18%     
- Complexity     3361     3400      +39     
============================================
  Files           662      668       +6     
  Lines         18266    18426     +160     
  Branches       1005     1008       +3     
============================================
+ Hits          11133    11265     +132     
- Misses         6729     6752      +23     
- Partials        404      409       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KarimGl KarimGl self-assigned this Oct 25, 2024
@KarimGl KarimGl added the enhancement New feature or request label Oct 25, 2024
@KarimGl KarimGl requested review from DelaunayAlex, boddissattva, bessonm and nbrouand and removed request for DelaunayAlex, boddissattva and bessonm October 25, 2024 20:15
@KarimGl KarimGl merged commit dd653ec into main Nov 18, 2024
3 checks passed
@KarimGl KarimGl deleted the feat/zip branch November 18, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants