Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#83] Create 'AssetError' and refactor 'select_asset' function to return it #97

Merged
merged 11 commits into from
Sep 18, 2022
Merged

[#83] Create 'AssetError' and refactor 'select_asset' function to return it #97

merged 11 commits into from
Sep 18, 2022

Commits on Sep 17, 2022

  1. Refactor select_asset() to use AssetError (NameUnknown or NotFound)

    @zixuan-x
    zixuan-x committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    9f0f719 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2022

  1. Add tests and format file

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    9bf1197 View commit details
    Browse the repository at this point in the history

  2. Add test for asset found

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    41ee6ad View commit details
    Browse the repository at this point in the history

  3. Remove todos from README.md

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    53b7360 View commit details
    Browse the repository at this point in the history

  4. Format code

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    7ea1c3f View commit details
    Browse the repository at this point in the history

  5. Add documentation for select_asset

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    1a9f95d View commit details
    Browse the repository at this point in the history

  6. Update src/model/release.rs 

    Co-authored-by: Dmitrii Kovanikov <[email protected]>
    @zixuan-x @chshersh
    zixuan-x and chshersh authored Sep 18, 2022
    Configuration menu
    Copy the full SHA
    184f7d9 View commit details
    Browse the repository at this point in the history

  7. Delete error Display trait test

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    87ce034 View commit details
    Browse the repository at this point in the history

  8. Rename NameUnknown error to OsSelectorUnknown

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    9d14b27 View commit details
    Browse the repository at this point in the history

  9. Fix linting

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    8f68103 View commit details
    Browse the repository at this point in the history

  10. Add test for OsSelectorUnknown

    @zixuan-x
    zixuan-x committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    0f634af View commit details
    Browse the repository at this point in the history