Better CI caching #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
force-pushed
the
chshersh/better-cache
branch
from
487a7a6
to
d46594f
Compare
|
Wow, 22s on Ubuntu instead of 1m and |
|
I don't think I have a lot to add here since I don't have ci experience with rust beyond running tests. The speed up definitely seems nice though! |
MitchellBerend
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches more directories on CI. These new directories are based on the following suggestions:
The
rust-cacheexplains some more details on why some directories should be cached and not others.Probably in the future, we will use
rust-cachedirectly. But for now, I believe it should be good enough to just cache extra few directories.I've noticed that
cargospends lots of time downloading the registry and sometimes even fails with spurious network errors. I believe this caching should address this problem.