Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add decompose function #88

Merged
merged 15 commits into from
Nov 12, 2021
Merged

add decompose function #88

merged 15 commits into from
Nov 12, 2021

Conversation

hillin
Copy link
Contributor

@hillin hillin commented Nov 2, 2021

Add implementation, type definition, test and documentation of the decompose function.

@hillin hillin mentioned this pull request Nov 2, 2021
Closed
@chrvadala chrvadala linked an issue Nov 2, 2021 that may be closed by this pull request
add decompose function #2
Closed
@hillin
Copy link
Contributor Author

hillin commented Nov 2, 2021

I'm working on fixing the code style issues. It seems I have some problem with the network, can't push yet. Will retry later.

chrvadala
chrvadala requested changes Nov 2, 2021
View reviewed changes
Copy link
Owner

@chrvadala chrvadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time in taking care of that. I send you some minor reviews.

Moreover, can you remove yarn.lock changes from this PR?

src/decompose.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/decompose.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 2, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling b48a4b7 on hillin:features/decompose into d6385eb on chrvadala:main.

@hillin
Copy link
Contributor Author

hillin commented Nov 3, 2021 •
edited
Loading

Moreover, can you remove yarn.lock changes from this PR?

What should I do? It's already deleted by a5a1921

chrvadala
chrvadala requested changes Nov 7, 2021
View reviewed changes
src/decompose.js Outdated Show resolved Hide resolved
src/decompose.js Outdated Show resolved Hide resolved
chrvadala
chrvadala requested changes Nov 8, 2021
View reviewed changes
Copy link
Owner

@chrvadala chrvadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for those changes, I feel that we are closer to merge this PR into the library.

src/decompose.js Show resolved Hide resolved
@chrvadala chrvadala self-requested a review November 10, 2021 23:48
chrvadala
chrvadala approved these changes Nov 10, 2021
View reviewed changes
Copy link
Owner

@chrvadala chrvadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! now it’s ready to be merged a released.
thanks a lot!!

@hillin
Copy link
Contributor Author

hillin commented Nov 11, 2021

Glad to contribute!

@chrvadala chrvadala merged commit dfcda88 into chrvadala:main Nov 12, 2021
@chrvadala
Copy link
Owner

Released with v2.10.0

@chrvadala chrvadala mentioned this pull request Nov 12, 2021
Closed
@hillin hillin deleted the features/decompose branch November 15, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrvadala chrvadala chrvadala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add decompose function
3 participants
@hillin @coveralls @chrvadala