-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.5 alpha compressed commits #794
Conversation
src/lib.rs
Outdated
#[cfg_attr(docsrs, doc(cfg(feature = "oldtime")))] | ||
extern crate time as oldtime; | ||
#[cfg(not(feature = "oldtime"))] | ||
mod oldtime; | ||
// this reexport is to aid the transition and should not be in the prelude! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove this line, too, right?
#[cfg_attr(docsrs, doc(cfg(feature = "oldtime")))] | ||
extern crate time as oldtime; | ||
#[cfg(not(feature = "oldtime"))] | ||
mod oldtime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this module declaration (and the import below, I suppose), I'm pretty sure this commit does not compile (and test). Would be nice to fix that properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yikes I must have grabbed this in the wrong commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm looks like I wiped out some commits when redoing them, will separate them again (I'm learning a bunch of git
features I never knew existed!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you did this using rebase -i, watch out for amending commits vs continuing the rebase, that's usually how I accidentally squash commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classic, that is exactly what I did! Should be right now, I've checked that it can compile at each commit
785fbb4
to
dfc49f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just needs a rebase.
Co-authored-by: Dirkjan Ochtman <[email protected]>
Co-authored-by: Dirkjan Ochtman <[email protected]>
Co-authored-by: Dirkjan Ochtman <[email protected]>
Co-authored-by: Dirkjan Ochtman <[email protected]>
Co-authored-by: Dirkjan Ochtman <[email protected]>
dfc49f1
to
3aa69af
Compare
I've pushed a 0.4.x branch from the HEAD of main before merging this. |
No description provided.