cshared: plugin: Tweak for workflow of registerWG #95
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, we have FLBPreRegister callback which is ensured to be executed before entering FLBPluginRegister. With using this callback, we can ensure the add/done sequence of registerWG wait group. Signed-off-by: Hiroshi Hatake <[email protected]>
|
Hmmm, fluent-bit side's implementation for loading external plugins including Golang plugins should be wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During to confirm the behavior of Golang plugin loading for fluent/fluent-bit#9729,
I found that Golang plugins are not loaded due to glitches of waitgroup add/done sequence.
Now, we have FLBPreRegister callback which is ensured to be executed before entering FLBPluginRegister.
With using this callback, we can ensure the add/done sequence of registerWG wait group.