-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace msgpack library #74
Conversation
Notice that CI is failing, but it was failing from before. There are too many lint problems (maybe the linter is too strict considering we are using many C idioms). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this change should not affect hot-reloading. And working as intended. But I'm still processing for how this replacement works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All confirmed for time related things. Looks attractive. 👍
Oh, I've overlooked for the requirements of this replacement. We need to handle timestamp related things to ordinary msgpack objects when it printed or ingested in the ordinary records. |
Right. This does not fixes the issue that fluent-bit still renders Go's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading this correctly this is mostly refactoring to replace the library.
If that's the case it looks good to me
Replace msgpack library from
github.com/ugorji/go/codec
github.com/vmihailenco/msgpack/v5
.There are still references to the old library in the subppackages that I didn't want to touch yet.
It has better support for (un)marshalling types like
time.Time
making tests more expectables.Also included tests from ##68 and msgpack unmarshalling into
map[string]any
instead ofmap[string]string
.Also did some chores and updated some dependencies, addressed some lint issues, etc.