Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: pass entire log as string using '%s' fmt to avoid fmt bugs. #49

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Sep 29, 2023

This basically escapes all log messages so they cannot cause crashes or be exploited.


@edsiper
Copy link
Contributor

edsiper commented Oct 2, 2023

better @cosmo0920 to review this.

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Even if with this change, we can format with fmt.Printf or fmt.Sprintf for messages in Golang side.

@edsiper edsiper merged commit a859c36 into main Oct 2, 2023
10 checks passed
@nicolasparada nicolasparada deleted the pwhelan-fix-fmt-log-bug branch June 6, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants