Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new configloader package #40

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Adds new configloader package #40

merged 1 commit into from
Aug 30, 2023

Conversation

niedbalski
Copy link
Contributor

In order to implement a new feature of the loader plugin, I need to retrieve
the configuration values for the custom plugins (optionally) that are persisted in the configuration.

Given the configuration pointer passed to the plugin only includes the config map relevant
for the plugin, I think that adding a helper method might be helpful.

For the near future, we can extend this loader to use env vars and fallback, and in the mid-term
future we will pass a parsed configuration (in the go-fluent-bit config schema) instead of the string
only schema we use now.

@niedbalski niedbalski requested a review from jasmingacic August 30, 2023 12:53
@niedbalski niedbalski self-assigned this Aug 30, 2023
Copy link

@jasmingacic jasmingacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully understanding what is going on.

So based on what I see here I'm approving it from the perspective of what the code is supposed to do not from functionality perspective

@niedbalski niedbalski merged commit 3e939c7 into main Aug 30, 2023
@nicolasparada nicolasparada deleted the configload branch June 6, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants