Fix quotes for configuration options #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need help, there is a I don't know how to fix this since it works great locally on MacOS, but fails on CI. |
niedbalski
requested changes
Aug 28, 2023
There was a problem hiding this comment.
Minor fix required. Indeed it works on mac. I will review this a bit deeper
➜ plugin (main) ✔ go test -v ./...
? github.com/calyptia/plugin/input [no test files]
? github.com/calyptia/plugin/metric [no test files]
? github.com/calyptia/plugin/metric/cmetric [no test files]
=== RUN TestPlugin
--- PASS: TestPlugin (101.05s)
PASS
ok github.com/calyptia/plugin 102.122s
=== RUN TestGetRecord
--- PASS: TestGetRecord (0.00s)
PASS
ok github.com/calyptia/plugin/output (cached)
Signed-off-by: Jorge Niedbalski <[email protected]>
niedbalski
changed the title
nicolasparada
commented
Aug 28, 2023
| @@ -37,6 +37,17 @@ func testPlugin(t *testing.T, pool *dockertest.Pool) { | |||
| f, err := os.Create(filepath.Join(t.TempDir(), "output.txt")) | |||
| assert.NoError(t, err) | |||
|
|
|||
| defer func() { | |||
| err := os.RemoveAll(f.Name()) | |||
There was a problem hiding this comment.
This is not required since I was using t.TempDir() and that entire directory gets removed once the test finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with quoted strings in config.
They are not unquoted when reading, causing unexpected results. For example, on the http_loader you can use multiline on the yaml format, when converting it back to classic format, everything gets inlined inside double quotes, and quotes inside the template functions get escaped. This causes template execution to fail. This PR should fix it.
Important. Looks like the tests were not working as expected and were not asserting anything. The output was split by
\nand then for each line was doing an assertion. But didn't check that there were no assertions...Now they run, but noticed that the output plugins fails with an error without enough details. Could not fix it on this PR, so for the test I stopped testing the output plugin and used a builtin fluent-bit plugin
filewhich does exactly what the output plugin in the tests does.We will have to fix this problem.
The error was just:
The output plugin error is unrelated to this PR so this should be good to merge.
https://app.asana.com/0/1205296321537082/1205365765880566