-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Device Orientation/Motion permission requests #88
Add Device Orientation/Motion permission requests #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Co-authored-by: Lucas Garron <[email protected]>
@lgarron All is done. Could you please merge this pull request? |
@lgarron , you are now marked as a co-author on this PR with your [email protected] email address. Would it be possible for you to sign the CLA with this email address? |
Sure, I'm actually surprised this hasn't come up before. :-P But the CLA process seems to suggest that I have to add it as an alternative email to my main GMail account, which I definitely don't want to. Do you know if there's another process I can use? |
Looks like an edge case where the solution was for me to manually override. I confirmed that you signed the CLA with this Github username with an other email address. |
Spec:
DeviceOrientationEvent.requestPermission()
: https://w3c.github.io/deviceorientation/#dom-deviceorientationevent-requestpermissionDeviceMotionEvent.requestPermission()
: https://w3c.github.io/deviceorientation/#dom-devicemotionevent-requestpermissionImplementations: