Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Device Orientation/Motion permission requests #88

Merged
merged 7 commits into from
Nov 29, 2021
Merged

Add Device Orientation/Motion permission requests #88

merged 7 commits into from
Nov 29, 2021

Conversation

FluorescentHallucinogen
Copy link
Contributor

@FluorescentHallucinogen FluorescentHallucinogen commented Nov 8, 2021

@FluorescentHallucinogen
Copy link
Contributor Author

@engedy @lgarron PTAL. 😉

Copy link
Collaborator

@lgarron lgarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@FluorescentHallucinogen
Copy link
Contributor Author

@lgarron All is done. Could you please merge this pull request?

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@engedy
Copy link
Collaborator

engedy commented Nov 10, 2021

@lgarron , you are now marked as a co-author on this PR with your [email protected] email address. Would it be possible for you to sign the CLA with this email address?

@lgarron
Copy link
Collaborator

lgarron commented Nov 10, 2021

@lgarron , you are now marked as a co-author on this PR with your [email protected] email address. Would it be possible for you to sign the CLA with this email address?

Sure, I'm actually surprised this hasn't come up before. :-P

But the CLA process seems to suggest that I have to add it as an alternative email to my main GMail account, which I definitely don't want to. Do you know if there's another process I can use?

@engedy
Copy link
Collaborator

engedy commented Nov 10, 2021

@lgarron , you are now marked as a co-author on this PR with your [email protected] email address. Would it be possible for you to sign the CLA with this email address?

Sure, I'm actually surprised this hasn't come up before. :-P

But the CLA process seems to suggest that I have to add it as an alternative email to my main GMail account, which I definitely don't want to. Do you know if there's another process I can use?

Looks like an edge case where the solution was for me to manually override. I confirmed that you signed the CLA with this Github username with an other email address.

@FluorescentHallucinogen
Copy link
Contributor Author

@engedy @lgarron All code review feedback has been addressed. Could you please take a look again and merge this pull request?

index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
@engedy engedy merged commit 29f41b8 into chromium:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants