Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use replacement build for baseline build with uncommitted changes #988

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 17, 2024

Addresses chromaui/addon-visual-tests#231

Similar to how we use a replacement build as baseline when an ancestor build's commit cannot be found, this will use a replacement build as baseline when the original baseline build had uncommitted changes.

📦 Published PR as canary version: 11.5.0--canary.988.9174965495.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@ghengeveld ghengeveld requested a review from tmeasday May 17, 2024 11:51
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 9847b421 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9847b42) Report Missing Report Missing Report Missing
Head commit (921b2b6) 8473 6675 78.78%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#988) 14 14 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ghengeveld ghengeveld changed the title Use replacement build when encountering baseline build with uncommitted changes Use replacement build for baseline build with uncommitted changes May 17, 2024
@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels May 17, 2024
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a question and a nit.

node-src/git/getBaselineBuilds.ts Show resolved Hide resolved
@ghengeveld ghengeveld added this pull request to the merge queue May 21, 2024
@ghengeveld ghengeveld removed this pull request from the merge queue due to a manual request May 21, 2024
@ghengeveld ghengeveld added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@ghengeveld ghengeveld added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 2c88ce4 May 21, 2024
26 of 27 checks passed
@ghengeveld ghengeveld deleted the 231-turbosnap-should-treat-uncommitted-builds-like-missing-commits branch May 21, 2024 12:46
@ghengeveld
Copy link
Member Author

🚀 PR was released in v11.4.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants