Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type declaration for isChromatic import #986

Merged
merged 1 commit into from
May 15, 2024

Conversation

ethriel3695
Copy link
Contributor

@ethriel3695 ethriel3695 commented May 14, 2024

(cherry picked from commit d75ed21)

I created a cherry-pick from the Fork since the CI process is failing on the Fork.

The original PR to fix the type import: #984

📦 Published PR as canary version: 11.3.4--canary.986.9096472441.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

(cherry picked from commit d75ed21)
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1d322d0) 8452 6650 78.68%
Head commit (01c3037) 8452 (+0) 6650 (+0) 78.68% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#986) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@ethriel3695 ethriel3695 added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels May 14, 2024
@ethriel3695 ethriel3695 self-assigned this May 14, 2024
@ethriel3695 ethriel3695 changed the title chore: fix types for main import patch: fix types for main import May 14, 2024
@ethriel3695 ethriel3695 added the bug Classification: Something isn't working label May 14, 2024
@ghengeveld ghengeveld changed the title patch: fix types for main import Fix type declaration for isChromatic import May 15, 2024
@ethriel3695 ethriel3695 added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 83675e6 May 15, 2024
31 of 32 checks passed
@ethriel3695 ethriel3695 deleted the reuben-update-types-import branch May 15, 2024 13:19
@ghengeveld
Copy link
Member

🚀 PR was released in v11.3.3 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants