Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose repositoryRootDir, configFile and fix diagnosticsFile #913

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Expose repositoryRootDir, configFile and fix diagnosticsFile #913

merged 6 commits into from
Feb 6, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Feb 6, 2024 •
edited
Loading

  • Add repositoryRootDir field to getGitInfo return value
  • Add configFile field to getConfiguration return value
  • Rename diagnosticFile to diagnosticsFile in configuration schema (misspelling)
📦 Published PR as canary version: 10.9.0--canary.913.7802662431.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@ghengeveld ghengeveld changed the title Expose repositoryRoot and configFile and fix diagnosticsFile property Expose repositoryRootDir, configFile and fix diagnosticsFile property Feb 6, 2024
@ghengeveld ghengeveld changed the title Expose repositoryRootDir, configFile and fix diagnosticsFile property Expose repositoryRootDir, configFile and fix diagnosticsFile Feb 6, 2024
@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Feb 6, 2024
andrewortwein
andrewortwein approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️📂🩺👍🏻

@ghengeveld ghengeveld enabled auto-merge February 6, 2024 15:08
@ghengeveld ghengeveld disabled auto-merge February 6, 2024 15:08
@ghengeveld ghengeveld added skip-release Auto: Preserve the current version when merged and removed release Auto: Create a `latest` release when merged labels Feb 6, 2024
@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged and removed skip-release Auto: Preserve the current version when merged labels Feb 6, 2024
@ghengeveld ghengeveld enabled auto-merge February 6, 2024 16:03
@ghengeveld ghengeveld added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit cc79dfb Feb 6, 2024
19 checks passed
@ghengeveld ghengeveld deleted the ghengeveld/ap-4149-detect-storybookdir-option branch February 6, 2024 16:08
@ghengeveld
Copy link
Member Author

🚀 PR was released in v10.8.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewortwein andrewortwein andrewortwein approved these changes

Assignees
No one assigned
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @andrewortwein