Add "package.json" to exports map #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook telemetry uses the package.json to determine the installed version of packages. Because the Chromatic CLI now has an exports map, but it does not contain package.json as an entry point, Storybook fails to read it, and therefore the version in the metadata is `null`. This PR fixes that!
yannbf
added
bug
thafryer
approved these changes
Jan 25, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook telemetry uses the package.json to determine the installed version of packages. Because the Chromatic CLI now has an exports map, but it does not contain package.json as an entry point, Storybook fails to read it, and therefore the version in the metadata is
null. This PR fixes that!Before:
After:
📦 Published PR as canary version:
10.5.1--canary.900.7652337120.0✨ Test out this PR locally via: