Add missing skip option to configuration schema
#890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbl-90
approved these changes
Jan 16, 2024
ghengeveld
added
release
|
🚀 PR was released in |
|
@ghengeveld this was an intentional omission. The rationale was why would you always want to skip? But perhaps folks are using specific config files for specific situations. In which case we might want to consider adding some other once-off flags. |
|
Skip can take a branch name glob, in which case it makes sense to specify that in the config file. E.g. to skip dependabot branches. |
|
Ahh, great point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #889
This option was documented and supposed to be available, but was omitted in the configuration schema. This adds the option so it can be used through
chromatic.config.json.📦 Published PR as canary version:
10.4.0--canary.890.7542881358.0✨ Test out this PR locally via: