-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write to log file and add --upload-metadata
to publish metadata files
#836
Conversation
--upload-metadata
to publish certain metadata files when the build finishes--upload-metadata
to publish certain metadata files
--upload-metadata
to publish certain metadata files--upload-metadata
to publish metadata files
--upload-metadata
to publish metadata files--upload-metadata
to publish metadata files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, this is great! However, you say:
these files will be public on a public Storybook.
That sounds like a deal breaker to me. Can we sync up on options for storing these more securely?
@tevanoff I opened a PR for the CDN to not allow public (non-member) access to these files. |
@ghengeveld perhaps change the PR description as this could unduly worry someone who reads this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good stuff
Fixes AP-3531, AP-2517
First of all, this updates our logging to write the CLI logs to a
chromatic.log
file besides printing to the terminal. The log file format is akin to what the logs look like in CI.Secondly, this adds an option to upload a set of "metadata" files, which will be available as part of the published Storybook in the
.chromatic
directory. A directory index is provided:📦 Published PR as canary version:
7.5.0--canary.836.6619467092.0
✨ Test out this PR locally via: