Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass runtime metadata in announceBuild #826

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Pass runtime metadata in announceBuild #826

merged 3 commits into from
Oct 10, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 2, 2023

Fixes AP-3715

Depends on https://github.com/chromaui/chromatic/pull/7763

This sends nodePlatform, nodeVersion, packageManager and packageManagerVersion when announcing a build, so that we can track this information.

I've split up the setSpawnParams job into setRuntimeMetadata (part of the initialize task) and setBuildCommand (part of the build task), so that the metadata is available earlier on in the build process, and also when we're not building Storybook. I got rid of the whole spawnParams concept because it's no longer relevant now that we're using @antfu/ni.

📦 Published PR as canary version: 7.3.0--canary.826.28d33af.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

…mand steps and pass runtimeMetadata to AnnounceBuild mutation
@linear
Copy link

linear bot commented Oct 2, 2023

AP-3715 Track Node.js and package manager version on builds

Keep track of nodePlatform, nodeVersion, packageManager and packageManagerVersion so that we can safely deprecate support for old versions and actively inform affected users about it.

Copy link
Contributor

@JonathanKolnik JonathanKolnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghengeveld ghengeveld added the minor Auto: Increment the minor version when merged label Oct 9, 2023
@ghengeveld ghengeveld added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit d6c989a Oct 10, 2023
@ghengeveld ghengeveld deleted the track-node-version branch October 10, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants