Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Jest to Vitest, update ESLint config and upgrade Execa #821

Merged
merged 11 commits into from
Sep 22, 2023
Merged

Migrate from Jest to Vitest, update ESLint config and upgrade Execa #821

merged 11 commits into from
Sep 22, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Sep 21, 2023 •
edited
Loading

All this to allow us to use AbortSignal with Execa...

@ghengeveld ghengeveld requested a review from tmeasday September 21, 2023 09:20
tmeasday
tmeasday approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine although I didn't review it all. Is there any thing in there I should look at?

@ghengeveld
Copy link
Member Author

@tmeasday The tests for getParentCommits use process.chdir which isn't supported in Vitest without passing --no-threads, so I ended up configuring it to run separately. I think that might be worth checking out but otherwise I feel pretty good about this change.

tmeasday
tmeasday approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

node-src/git/getParentCommits.test.ts Outdated Show resolved Hide resolved
@ghengeveld ghengeveld changed the base branch from ghengeveld/ap-3696-allow-user-to-cancel-build to main September 22, 2023 06:59
@ghengeveld ghengeveld merged commit d0c8cc5 into main Sep 22, 2023
14 checks passed
@ghengeveld ghengeveld deleted the upgrade-execa branch September 22, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @tmeasday