Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Nothing) #820

Merged
merged 5 commits into from
Sep 22, 2023
Merged

(Nothing) #820

merged 5 commits into from
Sep 22, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Sep 20, 2023

Superseded by #822

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…rror handling and reporting
@linear
Copy link

linear bot commented Sep 20, 2023

@ghengeveld ghengeveld requested a review from tmeasday September 20, 2023 21:53
@ghengeveld ghengeveld changed the title Add experimental_abortSignal for Node API to allow canceling builds before they're published Add experimental_abortSignal to Node API to allow canceling builds Sep 20, 2023
@ghengeveld ghengeveld force-pushed the ghengeveld/ap-3696-allow-user-to-cancel-build branch from fa3a277 to daa284a Compare September 20, 2023 22:14
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right approach.

node-src/tasks/build.ts Show resolved Hide resolved
@ghengeveld ghengeveld marked this pull request as ready for review September 22, 2023 06:57
@ghengeveld ghengeveld merged commit daa284a into main Sep 22, 2023
15 checks passed
@ghengeveld ghengeveld deleted the ghengeveld/ap-3696-allow-user-to-cancel-build branch September 22, 2023 07:26
@ghengeveld ghengeveld restored the ghengeveld/ap-3696-allow-user-to-cancel-build branch September 22, 2023 07:28
@ghengeveld
Copy link
Member Author

ghengeveld commented Sep 22, 2023

Wth GitHub, I didn't want to merge this yet.

@ghengeveld ghengeveld changed the title Add experimental_abortSignal to Node API to allow canceling builds - Sep 22, 2023
@ghengeveld ghengeveld changed the title - (Nothing) Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants